From owner-png-implement@dworkin.wustl.edu Mon Dec 1 03:12:53 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by maxwell.nde.swri.edu (8.8.6/8.8.5) with SMTP id DAA04964 for ; Mon, 1 Dec 1997 03:12:52 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id DAA20061 for png-implement-outgoing; Mon, 1 Dec 1997 03:07:35 -0600 Received: from thaumaturgist.AmbrosiaSW.com (AmbrosiaSW.com [206.27.96.210]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id DAA20056 for ; Mon, 1 Dec 1997 03:07:31 -0600 Received: from [209.130.133.95] by thaumaturgist.AmbrosiaSW.com via ESMTP (950911.SGI.8.6.12.PATCH825/940406.SGI.AUTO) for id DAA07993; Mon, 1 Dec 1997 03:29:51 -0500 Message-Id: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Mon, 1 Dec 1997 04:06:29 -0500 To: png-implement@dworkin.wustl.edu From: Matt Slot Subject: libpng questions Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Status: OR I'm working on a local port to the MacOS for libpng 0.96 / zlib 1.0.4, as well as writing up some high level wrappers. I've been able to create an offscreen image that matches the attributes of a given file (depth, color table, etc) -- and now I'd like to apply additional transforms: 1. I want to "suggest" a new color table for an image file that has one. 2. I want to expand an image with a color table into RGB (direct) pixels. The first should simply be a matter of using the existing dither mechanism, except to remap colors rather than approximate the run-off. However, I've tried several variations of parameters to png_set_dither() with little luck -- the dither table is not a straight map. I walked through the actual library routine, and was stopped at the hash table code without seeing a way to coerce it. The second is pretty much the opposite of the existing dither function -- it should look up the uncompressed pixel value as an index into the color table and construct a direct pixel value to store as output. A third transform (RGB direct -> color table) is already supported. Of course, these 2 transforms can be applied by "post-processing" the image and color table, but I'm wondering if the library supports them already (or whether it would be trivial to add). Basically, I'd *like* to be able to plot a PNG file right to the screen, and not have to make 2 passes over the pixel data. Thanks in advance, Matt +--------------------------+-----------------------------------+ | Matt Slot | Ambrosia Software, Inc. | | Bitwise Operator | http://www.AmbrosiaSW.com/ | +--------------------------+-----------------------------------+ -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Mon Dec 1 03:29:30 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by maxwell.nde.swri.edu (8.8.6/8.8.5) with SMTP id DAA04975 for ; Mon, 1 Dec 1997 03:29:29 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id DAA20196 for png-implement-outgoing; Mon, 1 Dec 1997 03:26:58 -0600 Received: from thaumaturgist.AmbrosiaSW.com (AmbrosiaSW.com [206.27.96.210]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id DAA20191 for ; Mon, 1 Dec 1997 03:26:55 -0600 Received: from [209.130.133.95] by thaumaturgist.AmbrosiaSW.com via ESMTP (950911.SGI.8.6.12.PATCH825/940406.SGI.AUTO) for id DAA08878; Mon, 1 Dec 1997 03:49:16 -0500 Message-Id: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Mon, 1 Dec 1997 04:25:54 -0500 To: png-implement@dworkin.wustl.edu From: Matt Slot Subject: libpng compile errors/warnings Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Status: OR Here is the fallout from yet another compiler: libpng 0.96 under MacOS CodeWarrior Pro 2. (I've made local modifications to fix them). In pngwutil.c, the function png_check_keyword() performs pointer arithmetic on "key" and "new_key", which are different pointer types. They should both be png_charpp. When #defining PNG_NO_STDIO to disable stderr, is not #included by , and errors pop up because FILE* is no longer defined. Thanks, Matt +--------------------------+-----------------------------------+ | Matt Slot | Ambrosia Software, Inc. | | Bitwise Operator | http://www.AmbrosiaSW.com/ | +--------------------------+-----------------------------------+ -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Mon Dec 1 13:28:34 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.6/8.8.5) with SMTP id NAA11807 for ; Mon, 1 Dec 1997 13:28:34 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id NAA26717 for png-implement-outgoing; Mon, 1 Dec 1997 13:29:24 -0600 Received: from iguana.reptiles.org (mail2.reptiles.org [198.96.117.130]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id NAA26700 for ; Mon, 1 Dec 1997 13:28:50 -0600 Received: from localhost (1196 bytes) by iguana.reptiles.org via send-mail with P:stdio/R:bind_hosts/T:inet_zone_bind_smtp (sender: ) (ident using unix) id for ; Mon, 1 Dec 1997 14:27:00 -0500 (EST) (Smail-3.2.0.97 1997-Aug-19 #1 built 1997-Oct-10) Message-Id: Date: Mon, 1 Dec 1997 14:27:00 -0500 (EST) From: smar@reptiles.org (Smarasderagd) To: png-implement@dworkin.wustl.edu Subject: Re: libpng questions Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Matt Slot writes: >1. I want to "suggest" a new color table for an image file that has one. With png_set_dither you can specify a palette to dither against, as shown in libpng.txt: if (png_get_valid(png_ptr, info_ptr, PNG_INFO_PLTE)) { png_color_16p histogram; png_get_hIST(png_ptr, info_ptr, &histogram); png_set_dither(png_ptr, palette, num_palette, max_screen_colors, histogram, 1); } libpng's dithering depends on the source image having a palette and/or histogram to make good colour choices; the streaming design means it can't build its own histogram. If you want the resulting image to be really good-looking rather than merely displayable you'll have to do your own dithering, taking advantage of all the image data. >2. I want to expand an image with a color table into RGB (direct) pixels. png_set_expand will turn a paletted image into an 8-bit RGB image. It also adds an alpha channel if there's any transparency information, so watch out. -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Mon Dec 1 21:03:52 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.6/8.8.5) with SMTP id VAA04718 for ; Mon, 1 Dec 1997 21:03:52 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id VAA02486 for png-implement-outgoing; Mon, 1 Dec 1997 21:05:12 -0600 Received: from aldus.northnet.org (aldus.northnet.org [198.175.11.2]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with SMTP id VAA02481 for ; Mon, 1 Dec 1997 21:05:08 -0600 Message-Id: <199712020305.VAA02481@dworkin.wustl.edu> Received: (qmail 15855 invoked by uid 0); 2 Dec 1997 03:05:51 -0000 Received: from ppp-56.canton.northnet.org (HELO Sal9000) (205.232.141.41) by aldus.northnet.org with SMTP; 2 Dec 1997 03:05:51 -0000 From: "John D. Gwinner" To: , Subject: Possible bug with png_get_rowbytes() Date: Mon, 1 Dec 1997 22:04:54 -0500 X-MSMail-Priority: Normal X-Priority: 3 X-Mailer: Microsoft Internet Mail 4.70.1161 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Hello: I'm building a Win32 version of the PNG library, with the current PNG and ZLib's. (Very cool product, BTW!). While testing some of the functions in example.c, I've tried the following combination of flags: if (color_type == PNG_COLOR_TYPE_PALETTE) png_set_expand(png_ptr); which seems to generate incorrect results at this point: row_pointers[row] = (unsigned char *) malloc(png_get_rowbytes(png_ptr, info_ptr)); as png_get_rowbytes returns 128, not the 128 * 3 that I'd expect? (assuming an RGB format, not RGBA or whatever). Is this correct behavior? Should I compensate for this, or should I make a bug fix in png_get_rowbytes by adding a multiplication factor assuming the output format bit depth could be different than the image bit depth? Thanks, and again a great format and a cool library. I hope I'm not asking a dumb question, and if I'm not, I hope I can help make the product better! Oh, one other note, that maybe should be in libpng.txt, is that when making a .DLL, you've got to be careful with default libraries under Win32. If you link with the default libraries, your application and the DLL may use different C run times, meaning that you can't pass FILE *'s between the app and your DLL. You need to check "ignore default libraries" and then manually specify MSVCRTD.LIB (or your own choice of CRT) and OLDNAMES.LIB. OldNames is only needed for one function link, but I forget what it was (I think it was _fdopen, but I forget where it tied in). == John == == John D. Gwinner == == VisNet, Inc == "Making CyberSpace Real" (TM) == VisNet, Vis-CIS, and Vis-It are also trademarks of VisNet, Inc == for more info: http://www.vis-net.com == or mailto:visnet@compuserve.com -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Mon Dec 1 21:24:28 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.6/8.8.5) with SMTP id VAA05353 for ; Mon, 1 Dec 1997 21:24:28 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id VAA02792 for png-implement-outgoing; Mon, 1 Dec 1997 21:25:21 -0600 Received: from mail1.microsoft.com (mail1.microsoft.com [131.107.3.41]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id VAA02785 for ; Mon, 1 Dec 1997 21:25:18 -0600 Received: by INET-01-IMC with Internet Mail Service (5.5.1960.3) id ; Mon, 1 Dec 1997 19:23:35 -0800 Message-ID: <71F299426E8CCF11B05600805F6809DF01512DA6@cup-01-msg.dns.microsoft.com> From: John Bowler To: PNG Implementation List Subject: RE: libpng questions Date: Mon, 1 Dec 1997 19:24:09 -0800 X-Mailer: Internet Mail Service (5.5.1960.3) Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List > From: Matt Slot [SMTP:fprefect@ambrosiasw.com] >I'm working on a local port to the MacOS for libpng 0.96 / zlib 1.0.4, as >well as writing up some high level wrappers. I've been able to create an >offscreen image that matches the attributes of a given file (depth, color >table, etc) -- and now I'd like to apply additional transforms: > >1. I want to "suggest" a new color table for an image file that has one. >2. I want to expand an image with a color table into RGB (direct) pixels. > >The first should simply be a matter of using the existing dither mechanism, >except to remap colors rather than approximate the run-off. I.e. you want to have the library map the pixel values to the values which correspond to the closest color on the available hardware - that's not what the library does because it is dithering the pixel colors to get the best match. Like your second transform it is a mapping to a specific hardware layout (I think this is what you want) rather than the existing transforms which are mapping to more generic color representations. It just so happens that in many cases the color mapping happens to produce a memory layout which matches the hardware layout, but it isn't necessarily so. >However, I've >tried several variations of parameters to png_set_dither() with little luck >-- the dither table is not a straight map. I walked through the actual >library routine, and was stopped at the hash table code without seeing a >way to coerce it. You can precompute the mapping - doing it from an RGB lookup is extremely inefficient. >The second is pretty much the opposite of the existing dither function -- >it should look up the uncompressed pixel value as an index into the color >table and construct a direct pixel value to store as output. By chance the QuickDraw layout xRGB happens to match the PNG RGBA layout if you shift it by one byte, but this more than a little of a hack (and doesn't work on, for example, Win32 where the layout is BGRx). It also doesn't help with RGBDirect where the cmpCount (bits per component) is 5 - i.e. 16bpp forms. Handling all of these things is very hardware specific. >Of course, these 2 transforms can be applied by "post-processing" the >image and color table, but I'm wondering if the library supports them >already (or whether it would be trivial to add). Basically, I'd *like* >to be able to plot a PNG file right to the screen, and not have to make >2 passes over the pixel data. If you look at what the library does you will find that it ends up copying things when it could avoid it anyway. The data comes out of zlib in the PNG format (but filtered) and it is unavoidable (unless you want to reimplement the guts of inflate in a PNG specific way) that there will be a further translation in the cases you identify. When I faced this problem I, eventually, made the implementation decision not to use the PNG library (except by copy/paste) and to use Zlib directly. I was also able to make the decision to implement just Win and Mac support - so this immediately restricted the memory formats I have to handle. Even so on both platforms the code doesn't go directly to the screen - both operating systems provide efficient ways of getting bitmaps to the screen (very minor overhead compared to other operations) and both also provide acceptable support for many of the transformations in the library (e.g. ditherCopy on the Mac.) Even if you use the library it is possible to avoid the transformations (so the only pixel touching operation after zlib is filtering) and then do a simple hardware specific transformation at the end (probably in-place). John Bowler -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Mon Dec 1 22:12:44 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.6/8.8.5) with SMTP id WAA05592 for ; Mon, 1 Dec 1997 22:12:43 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id WAA03153 for png-implement-outgoing; Mon, 1 Dec 1997 22:14:07 -0600 Received: from iguana.reptiles.org (mail2.reptiles.org [198.96.117.130]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id WAA03148 for ; Mon, 1 Dec 1997 22:14:03 -0600 Received: from localhost (883 bytes) by iguana.reptiles.org via send-mail with P:stdio/R:bind_hosts/T:inet_zone_bind_smtp (sender: ) (ident using unix) id for ; Mon, 1 Dec 1997 23:12:15 -0500 (EST) (Smail-3.2.0.97 1997-Aug-19 #1 built 1997-Oct-10) Message-Id: Date: Mon, 1 Dec 1997 23:12:15 -0500 (EST) From: smar@reptiles.org (Smarasderagd) To: png-implement@dworkin.wustl.edu Subject: Re: Possible bug with png_get_rowbytes() Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List "John D. Gwinner" writes: > While testing some of the functions in example.c, I've tried the >following combination of flags: > > if (color_type == PNG_COLOR_TYPE_PALETTE) > png_set_expand(png_ptr); > >which seems to generate incorrect results at this point: > >row_pointers[row] = (unsigned char *) malloc(png_get_rowbytes(png_ptr, >info_ptr)); > >as png_get_rowbytes returns 128, not the 128 * 3 that I'd expect? >(assuming an RGB format, not RGBA or whatever). I think you need to call png_read_update_info before calling png_get_rowbytes to get the row size for the output image. Until png_read_update_info is called, all the information still refers to the input PNG format. -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 16 02:05:09 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id CAA05221 for ; Tue, 16 Dec 1997 02:05:09 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id CAA06244 for png-implement-outgoing; Tue, 16 Dec 1997 02:06:47 -0600 Received: from m6.sprynet.com (m6.sprynet.com [165.121.2.89]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id CAA06239 for ; Tue, 16 Dec 1997 02:06:39 -0600 Received: from stormyweather (hd75-210.hil.compuserve.com [206.175.185.210]) by m6.sprynet.com (8.6.12/8.6.12) with SMTP id AAA05043 for ; Tue, 16 Dec 1997 00:03:30 -0800 Message-Id: <199712160803.AAA05043@m6.sprynet.com> Comments: Authenticated sender is From: "soren andersen" To: png-implement@dworkin.wustl.edu Date: Tue, 16 Dec 1997 03:03:28 -0005 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Subject: Greg Roelofs: plugin info for PNG Priority: normal X-mailer: Pegasus Mail for Win32 (v2.42a) Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Greg & all, I have found a new browser plugin / viewer application that supports PNG (that is, its support may or may not be new and it, the plugin, may or may not be particularly new; but its support of PNG is news to me, and to the PNG homepage Greg maintains). The relevant page on the website maintained by Greg: http://www.cdrom.com/pub/png/pngapbr.html ------------------------------------------------------- The info on the Netscape plugin: "Supported file formats for Quick View Plus 4.5" - (http://www5.eps.inso.com/) Portable Network Graphics (PNG) 1.0 [ exactly what does INSO corp mean by "PNG 1.0", i wonder? ] I have not tried this plugin out. I am not going to either, for the foreseeable future, since i have the latest browsers installed and have no need and no extra disk space at present for another browser installation. Anyway, i know that now, with Netscape having finally begun to support PNG internally, it may be of less interest to track down who has released what plugins; however i think there is still some reason for interest as not everyone will use generation 4 browsers immediately (for better or worse) and so plugins for Netscape are probably still of relevance. BTW, has anyone ever posted to this list a JavaScript module (so to speak) that will determine plugin presence, browser version etc and dynamically write HTML tags to present PNG images to different browsers in the way that they need (i.e. Netscape pre-4.04 tags and post-4.04 tags)? soren andersen MyFavoriteThings http://ourworld.compuserve.com/homepages/sorentino/ Home of the arbn newsgroup documentation subsite - directly at: http://ourworld.compuserve.com/homepages/sorentino/arbn/intro_pg.htm ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 16 11:52:26 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id LAA27028 for ; Tue, 16 Dec 1997 11:52:26 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id LAA11181 for png-implement-outgoing; Tue, 16 Dec 1997 11:55:01 -0600 Received: from dancris.com (user1.dancris.com [204.177.80.10]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id LAA11175 for ; Tue, 16 Dec 1997 11:54:58 -0600 Received: by dancris.com (8.8.5/DANCRIS-1.2) id KAA20811 for ; Tue, 16 Dec 1997 10:51:31 -0700 (MST) From: lionlad@dancris.com (Rob Poole) Message-Id: <199712161751.KAA20811@dancris.com> Subject: Re: Greg Roelofs: plugin info for PNG To: png-implement@dworkin.wustl.edu Date: Tue, 16 Dec 1997 10:51:31 -0700 (MST) In-Reply-To: <199712160803.AAA05043@m6.sprynet.com> from "soren andersen" at Dec 16, 97 03:03:28 am X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Since which version has Netscape supported PNG internally? I thought that only Internet Explorer 4.x supported PNG internally -- I have Netscape Communicator 4.03, and it will not support PNG images, AFAIK. (I just tested it against my home page, http://www.dancris.com/~lionlad, which has a single PNG image.) Rob Poole lionlad@dancris.com -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 16 13:23:57 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id NAA00837 for ; Tue, 16 Dec 1997 13:23:56 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id NAA12234 for png-implement-outgoing; Tue, 16 Dec 1997 13:26:36 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id NAA12229 for ; Tue, 16 Dec 1997 13:26:33 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id OAA03542; Tue, 16 Dec 1997 14:23:23 -0500 Message-Id: <1.5.4.32.19971216192111.006f77dc@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Tue, 16 Dec 1997 14:21:11 -0500 To: PNG Implementation List From: Glenn Randers-Pehrson Subject: Re: Greg Roelofs: plugin info for PNG Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 10:51 AM 12/16/97 -0700, Rob Poole wrote: >Since which version has Netscape supported PNG internally? NC 4.04 > I thought >that only Internet Explorer 4.x supported PNG internally -- I have >Netscape Communicator 4.03, and it will not support PNG images, AFAIK. Right. NC 4.04 came out very recently and it supports inline (IMG) PNG but half-heartedly-- no transparency or alpha. Glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 16 14:39:58 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id OAA04314 for ; Tue, 16 Dec 1997 14:39:57 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id OAA13694 for png-implement-outgoing; Tue, 16 Dec 1997 14:42:39 -0600 Received: from m6.sprynet.com (m6.sprynet.com [165.121.2.89]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id OAA13689 for ; Tue, 16 Dec 1997 14:42:35 -0600 Received: from stormyweather (dd53-098.dub.compuserve.com [199.174.184.98]) by m6.sprynet.com (8.6.12/8.6.12) with SMTP id MAA01547 for ; Tue, 16 Dec 1997 12:39:24 -0800 Message-Id: <199712162039.MAA01547@m6.sprynet.com> Comments: Authenticated sender is From: "soren andersen" To: png-implement@dworkin.wustl.edu Date: Tue, 16 Dec 1997 15:39:21 -0005 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Subject: Re: Greg Roelofs: plugin info for PNG Priority: normal X-mailer: Pegasus Mail for Win32 (v2.42a) Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List On 16 Dec 97 in the matter of Re: Greg Roelofs: plugin info for P, Rob Poole wrote: > Since which version has Netscape supported PNG internally? I thought that > only Internet Explorer 4.x supported PNG internally -- I have Netscape > Communicator 4.03, and it will not support PNG images, AFAIK. (I just > tested it against my home page, http://www.dancris.com/~lionlad, which has > a single PNG image.) > > Rob Poole > lionlad@dancris.com :-) Since v4.04, Rob ... you must have just subscribed to the list ... and just missed the flurry of news on this, last 3-4 weeks. However, note that some important features of PNG are broken in the current Navigator - notably any support for alpha transparency. Some of us are contemplating or suggesting a mild email campaign directed towards Netscape to nudge them towards finishing the job right, and as soon as possible. :-) soren andersen - Those who are offended by smileys should mentally delete them from my text. sorentin@sprynet.com --{--{@ How perilous is it to choose, not to love this life we're shown? -Seamus Heaney from "The Badgers" -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 16 16:07:43 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id QAA08313 for ; Tue, 16 Dec 1997 16:07:43 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id QAA14632 for png-implement-outgoing; Tue, 16 Dec 1997 16:10:15 -0600 Received: from dancris.com (user1.dancris.com [204.177.80.10]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id QAA14627 for ; Tue, 16 Dec 1997 16:10:12 -0600 Received: by dancris.com (8.8.5/DANCRIS-1.2) id PAA15070 for ; Tue, 16 Dec 1997 15:06:52 -0700 (MST) From: lionlad@dancris.com (Rob Poole) Message-Id: <199712162206.PAA15070@dancris.com> Subject: Re: Greg Roelofs: plugin info for PNG To: png-implement@dworkin.wustl.edu Date: Tue, 16 Dec 1997 15:06:52 -0700 (MST) In-Reply-To: <199712162039.MAA01547@m6.sprynet.com> from "soren andersen" at Dec 16, 97 03:39:21 pm X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List > :-) Since v4.04, Rob ... you must have just subscribed to the list ... Nope, been on the list since the beginning, almost. I was contributor since before PNG was a standard, or even a finalized spec. Guess I've been busy with a lot of work lately (and more to come, what with me moving to Austin to take a job with Metrowerks). Rob Poole lionlad@dancris.com -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 16 21:09:46 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id VAA16420 for ; Tue, 16 Dec 1997 21:09:45 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id VAA17658 for png-implement-outgoing; Tue, 16 Dec 1997 21:12:23 -0600 Received: from buffy.graphicswiz.com (buffy.graphicswiz.com [207.239.128.194]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id VAA17653 for ; Tue, 16 Dec 1997 21:12:20 -0600 Received: (from nobody@localhost) by buffy.graphicswiz.com (8.8.7/8.6.9) id VAA22221 for ; Tue, 16 Dec 1997 21:12:49 -0600 X-Authentication-Warning: buffy.graphicswiz.com: nobody set sender to using -f Received: from sally.graphicswiz.com(10.10.10.3) by buffy.graphicswiz.com via smap (V2.0) id xma022212; Tue, 16 Dec 97 21:12:41 -0600 Received: from katie (katie.graphicswiz.com [10.10.10.250]) by sally.graphicswiz.com (8.8.7/8.6.9) with SMTP id VAA22776 for ; Tue, 16 Dec 1997 21:12:39 -0600 Date: Tue, 16 Dec 1997 21:12:39 -0600 Message-Id: <199712170312.VAA22776@sally.graphicswiz.com> X-Sender: pschmidt@mail X-Mailer: Windows Eudora Version 1.4.4 Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" To: PNG Implementation List From: pschmidt@photodex.com (Paul Schmidt) Subject: Re: Greg Roelofs: plugin info for PNG Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List >> :-) Since v4.04, Rob ... you must have just subscribed to the list ... > >Nope, been on the list since the beginning, almost. I was contributor >since before PNG was a standard, or even a finalized spec. > >Guess I've been busy with a lot of work lately (and more to come, what >with me moving to Austin to take a job with Metrowerks). > >Rob Poole >lionlad@dancris.com Rob, You should look me up (pschmidt@photodex.com) and let's play some golf! :-) Best Regards, Paul Schmidt ---------------------------------------------------------- Photodex Corporation Service GO/Keyword E-Mail 1106 Clayton Lane #200W AOL: Photodex Photodex Austin, TX 78723 CIS: Photodex 74774,3635 (512)406-3020 Voice (512)452-6825 Fax i'net: pschmidt@photodex.com "I play with dots... WWW: http://www.photodex.com ...lots of dots." FTP: ftp.photodex.com -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Thu Dec 18 12:13:35 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id MAA07236 for ; Thu, 18 Dec 1997 12:13:34 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id MAA10192 for png-implement-outgoing; Thu, 18 Dec 1997 12:15:46 -0600 Received: from shell.wco.com (shell.wco.com [199.4.94.16]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id MAA10187 for ; Thu, 18 Dec 1997 12:15:39 -0600 Received: (from png@localhost) by shell.wco.com (8.8.5/8.8.5/WCO-18jul97) id KAA13512; Thu, 18 Dec 1997 10:12:18 -0800 (PST) Date: Thu, 18 Dec 1997 10:12:18 -0800 (PST) Message-Id: <199712181812.KAA13512@shell.wco.com> To: png-implement@dworkin.wustl.edu Subject: Re: Greg Roelofs: plugin info for PNG From: Greg Roelofs Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Soren wrote: > I have found a new browser plugin / viewer application that supports PNG (that is, > its support may or may not be new and it, the plugin, may or may not be particularly > new; but its support of PNG is news to me, and to the PNG homepage Greg > maintains). I had it listed as an image viewer, not a plug-in. I've moved it to the browsers page now. Thanks, Greg -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Tue Dec 23 19:51:59 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id TAA12980 for ; Tue, 23 Dec 1997 19:51:57 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id TAA23263 for png-implement-outgoing; Tue, 23 Dec 1997 19:55:15 -0600 Received: from is.ciet.cn.net ([202.96.57.1]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id TAA23224; Tue, 23 Dec 1997 19:51:40 -0600 Received: from o2.ciet.cn.net by is.ciet.cn.net via ESMTP (950413.SGI.8.6.12/940406.SGI.AUTO) id IAA08350; Wed, 24 Dec 1997 08:51:28 -0800 Received: from o2 (localhost [127.0.0.1]) by o2.ciet.cn.net (950413.SGI.8.6.12/950213.SGI.AUTOCF) via SMTP id VAA04660; Wed, 24 Dec 1997 21:42:27 +0800 Message-ID: <34A11142.2781@o2.moftec.gov.cn> Date: Wed, 24 Dec 1997 21:42:26 +0800 From: Jie Wu Organization: personal X-Mailer: Mozilla 3.0SC-SGI (X11; I; IRIX 6.3 IP32) MIME-Version: 1.0 To: png-info@uunet.uu.net CC: png-list@dworkin.wustl.edu, png-implement@dworkin.wustl.edu Subject: question about ranlib Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Hi, Folks, Merry Christmas! (if this is a mailing list, please also send your response to my email "mailto:wujie@o2.moftec.gov.cn") I read from "http://www.group42.com/develop.htm" that "PNG support can be obtained via email at png-info@uunet.uu.net." So I write to this address. Thanks in advance. I have problems building "libpng-0.96", my system is IRIX 6.3 IP32. When I make use the default makefile, I was given: ----------------------------------------------------------------------- cc -I/usr/local/include -O -c png.c cc -I/usr/local/include -O -c pngset.c cc -I/usr/local/include -O -c pngget.c cc -I/usr/local/include -O -c pngrutil.c cc -I/usr/local/include -O -c pngtrans.c cc -I/usr/local/include -O -c pngwutil.c cc -I/usr/local/include -O -c pngread.c cc -I/usr/local/include -O -c pngrio.c cc -I/usr/local/include -O -c pngwio.c cc -I/usr/local/include -O -c pngwrite.c cc -I/usr/local/include -O -c pngrtran.c cc -I/usr/local/include -O -c pngwtran.c cc -I/usr/local/include -O -c pngmem.c cc -I/usr/local/include -O -c pngerror.c cc -I/usr/local/include -O -c pngpread.c ar rc libpng.a png.o pngset.o pngget.o pngrutil.o pngtrans.o pngwutil.o pngread.o pngrio.o pngwio.o pngwrite.o pngrtran.o pngwtran.o pngmem.o pngerror.o pngpread.o ranlib libpng.a sh: ranlib: not found *** Error code 127 (bu21) ----------------------------------------------------------------------- Seems "ranlib" is a UNIX command dealing with the assembly file, isn't it? I searched the system and find no file named "ranlib". How can I solve this problem? What's the usage of "ranlib"? Are there any web resources focusing on this subject? -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 24 14:21:03 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id OAA16608 for ; Wed, 24 Dec 1997 14:21:03 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id OAA02303 for png-implement-outgoing; Wed, 24 Dec 1997 14:24:28 -0600 Received: from iguana.reptiles.org (mail2.reptiles.org [198.96.117.130]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id OAA02298 for ; Wed, 24 Dec 1997 14:24:25 -0600 Received: from localhost (374 bytes) by iguana.reptiles.org via send-mail with P:stdio/R:bind_hosts/T:inet_zone_bind_smtp (sender: ) (ident using unix) id for ; Wed, 24 Dec 1997 15:20:29 -0500 (EST) (Smail-3.2.0.97 1997-Aug-19 #1 built 1997-Oct-10) Message-Id: Date: Wed, 24 Dec 1997 15:20:29 -0500 (EST) From: smar@reptiles.org (Smarasderagd) To: png-implement@dworkin.wustl.edu, wujie@o2.moftec.gov.cn Subject: Re: question about ranlib Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List On some systems "ar" performs the work of ranlib, so ranlib isn't necessary. If there's no SGI makefile, try just commenting out the 'ranlib' line and see if it works. -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 24 19:04:04 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id TAA17202 for ; Wed, 24 Dec 1997 19:04:04 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id TAA04751 for png-implement-outgoing; Wed, 24 Dec 1997 19:07:34 -0600 Received: from is.ciet.cn.net ([202.96.57.1]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id TAA04746 for ; Wed, 24 Dec 1997 19:07:27 -0600 Received: from o2.ciet.cn.net by is.ciet.cn.net via ESMTP (950413.SGI.8.6.12/940406.SGI.AUTO) id IAA09537; Thu, 25 Dec 1997 08:06:58 -0800 Received: from o2 (localhost [127.0.0.1]) by o2.ciet.cn.net (950413.SGI.8.6.12/950213.SGI.AUTOCF) via SMTP id UAA06671; Thu, 25 Dec 1997 20:57:56 +0800 Message-ID: <34A25853.41C6@o2.moftec.gov.cn> Date: Thu, 25 Dec 1997 20:57:55 +0800 From: Jie Wu Organization: personal X-Mailer: Mozilla 3.0SC-SGI (X11; I; IRIX 6.3 IP32) MIME-Version: 1.0 To: Thomas Boutell , Smarasderagd CC: png-implement@dworkin.wustl.edu Subject: Re: question about ranlib Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Thanks to all that provided information. After I made some changes from the suggestion of Mr. Glenn Randers-Pehrson , the "make" passed. This is maybe a long-standing problem with SGI. The solution is simple: ln /bin/true /bin/ranlib That's all. Have a nice holiday! -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 14:19:56 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id OAA27614 for ; Wed, 31 Dec 1997 14:19:55 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id OAA29931 for png-implement-outgoing; Wed, 31 Dec 1997 14:23:01 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id OAA29926 for ; Wed, 31 Dec 1997 14:22:53 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id PAA12222; Wed, 31 Dec 1997 15:18:17 -0500 Message-Id: <1.5.4.32.19971231201554.00732360@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 15:15:54 -0500 To: PNG Implementation List From: Glenn Randers-Pehrson Subject: RE: png_set_text - memory leak (mine or libpng's ?) Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 12:13 PM 11/19/97 -0800, John Bowler wrote: >> From: smar@reptiles.org [SMTP:smar@reptiles.org] >>| png_destroy_write_struct(&png_ptr, &info_ptr); >>| >>| You must free any data you allocated for info_ptr, such as comments, >>| palette, or histogram, before the call to png_destroy_write_struct(); >> >>So it looks like you have to free info_ptr->text yourself. >> >>This is a rather bad state of affairs. The PNG library ought to be >>responsible for freeing anything it allocated, > >Yes, a good rule. > [...] >The info_ptr->text is, however, allocated by the png_set_text function so >should be freed by png_write_destroy. [...] >I have no problem with the approach in 0.8x and no >problem with that in 0.9x except where the behavior is inconsistent. I >think in this case it is inconsistent, so should probably be changed. > >John Bowler Has there been any further thought on this? Would the following be sufficient? In pngwrite.c at line 530, insert the line marked with "+": if (info_ptr != NULL) { + png_free(png_ptr, info_ptr->text); png_destroy_struct((png_voidp)info_ptr); *info_ptr_ptr = (png_structp)NULL; } Chris Losinger, would this fix the leak that you observed? Break anything? Glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 14:41:02 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id OAA28016 for ; Wed, 31 Dec 1997 14:41:01 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id OAA00324 for png-implement-outgoing; Wed, 31 Dec 1997 14:45:22 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id OAA00319 for ; Wed, 31 Dec 1997 14:45:19 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id PAA13128; Wed, 31 Dec 1997 15:40:48 -0500 Message-Id: <1.5.4.32.19971231203825.0071a528@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 15:38:25 -0500 To: png-implement@dworkin.wustl.edu From: Glenn Randers-Pehrson Subject: RE: png_set_text - memory leak (mine or libpng's ?) Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 03:15 PM 12/31/97 -0500, I wrote: > Would the following be sufficient? > >In pngwrite.c at line 530, insert the line marked with "+": > > if (info_ptr != NULL) > { > + png_free(png_ptr, info_ptr->text); > png_destroy_struct((png_voidp)info_ptr); > *info_ptr_ptr = (png_structp)NULL; > } Oops, I neglected to surround the added statement with the appropriate ifdef: In pngwrite.c at line 530, insert the lines marked with "+": if (info_ptr != NULL) { + #ifdef PNG_WRITE_tEXt_SUPPORTED + png_free(png_ptr, info_ptr->text); + #endif png_destroy_struct((png_voidp)info_ptr); *info_ptr_ptr = (png_structp)NULL; } Glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 15:09:56 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id PAA28528 for ; Wed, 31 Dec 1997 15:09:55 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id PAA00538 for png-implement-outgoing; Wed, 31 Dec 1997 15:14:13 -0600 Received: from pagesz.net (nina.pagesz.net [208.194.157.3]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id PAA00533 for ; Wed, 31 Dec 1997 15:14:10 -0600 Received: from chrisdl.pagesz.net (isabella-55.pagesz.net [208.194.157.55]) by pagesz.net (8.8.5/8.8.4) with SMTP id QAA25444 for ; Wed, 31 Dec 1997 16:09:39 -0500 Message-ID: <34AAB3AE.1179@pagesz.net> Date: Wed, 31 Dec 1997 16:05:50 -0500 From: chris losinger X-Mailer: Mozilla 3.01Gold (Win95; I) MIME-Version: 1.0 To: PNG Implementation List Subject: Re: png_set_text - memory leak (mine or libpng's ?) References: <1.5.4.32.19971231201554.00732360@netgsi.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List Glenn Randers-Pehrson wrote: > > Has there been any further thought on this? Would the following > be sufficient? > > In pngwrite.c at line 530, insert the line marked with "+": > > if (info_ptr != NULL) > { > + png_free(png_ptr, info_ptr->text); > png_destroy_struct((png_voidp)info_ptr); > *info_ptr_ptr = (png_structp)NULL; > } > > Chris Losinger, would this fix the leak that you observed? Break anything? > yes. i did it like this : if (info_ptr != NULL) { + if (info_ptr->text!=NULL) { + png_free(png_ptr, info_ptr->text); + } png_destroy_struct((png_voidp)info_ptr); *info_ptr_ptr = (png_infop)NULL; } -- ----------------------------------------------------------------------- c h r i s l o s i n g e r chrisdl@pagesz.net http://www.pagesz.net/~chrisdl Baby Sam's first word was "encrypt". -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 15:53:24 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id PAA29275 for ; Wed, 31 Dec 1997 15:53:24 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id PAA00910 for png-implement-outgoing; Wed, 31 Dec 1997 15:57:24 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id PAA00905 for ; Wed, 31 Dec 1997 15:57:21 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id QAA15964; Wed, 31 Dec 1997 16:52:49 -0500 Message-Id: <1.5.4.32.19971231215026.00729260@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 16:50:26 -0500 To: PNG Implementation List From: Glenn Randers-Pehrson Subject: Re: png_set_text - memory leak (mine or libpng's ?) Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 04:05 PM 12/31/97 -0500, you wrote: >> Chris Losinger, would this fix the leak that you observed? Break anything? >> > yes. i did it like this : > > if (info_ptr != NULL) > { >+ if (info_ptr->text!=NULL) { >+ png_free(png_ptr, info_ptr->text); >+ } > > png_destroy_struct((png_voidp)info_ptr); > *info_ptr_ptr = (png_infop)NULL; > } Doesn't seem necessary to do the test because the first thing png_free does is to check its args and return without action if either is NULL. Glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 16:29:23 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id QAA00030 for ; Wed, 31 Dec 1997 16:29:23 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id QAA01228 for png-implement-outgoing; Wed, 31 Dec 1997 16:33:44 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id QAA01223 for ; Wed, 31 Dec 1997 16:33:40 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id RAA17233; Wed, 31 Dec 1997 17:29:08 -0500 Message-Id: <1.5.4.32.19971231222645.00721a40@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 17:26:45 -0500 To: PNG Implementation List From: Glenn Randers-Pehrson Subject: Re: Possible bug with png_get_rowbytes() Cc: "John D. Gwinner" Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 11:12 PM 12/1/97 -0500, you wrote: >"John D. Gwinner" writes: >> While testing some of the functions in example.c, I've tried the >>following combination of flags: >> >> if (color_type == PNG_COLOR_TYPE_PALETTE) >> png_set_expand(png_ptr); >> >>which seems to generate incorrect results at this point: >> >>row_pointers[row] = (unsigned char *) malloc(png_get_rowbytes(png_ptr, >>info_ptr)); >> >>as png_get_rowbytes returns 128, not the 128 * 3 that I'd expect? >>(assuming an RGB format, not RGBA or whatever). > >I think you need to call png_read_update_info before calling >png_get_rowbytes to get the row size for the output image. >Until png_read_update_info is called, all the information still >refers to the input PNG format. Can we close this thread? John, did you try Smar's recommendation? Is there any mod needed to libpng (I don't think so)? Glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 17:01:12 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id RAA01152 for ; Wed, 31 Dec 1997 17:01:12 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id RAA01447 for png-implement-outgoing; Wed, 31 Dec 1997 17:05:12 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id RAA01442 for ; Wed, 31 Dec 1997 17:05:09 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id SAA18385; Wed, 31 Dec 1997 18:00:38 -0500 Message-Id: <1.5.4.32.19971231225815.0074e364@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 17:58:15 -0500 To: PNG Implementation List From: Glenn Randers-Pehrson Subject: Re: libpng compile errors/warnings Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 04:25 AM 12/1/97 -0500, Matt Lot wrote: >When #defining PNG_NO_STDIO to disable stderr, is not #included >by , and errors pop up because FILE* is no longer defined. I haven't seen an answer to this question. It seems as though the right thing is to include in pngconf.h regardless of the condition of PNG_NO_STDIO. (Just delete the #ifndef/#endif surrounding the #include stdio directive) Glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 18:22:57 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id SAA03189 for ; Wed, 31 Dec 1997 18:22:56 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id SAA02031 for png-implement-outgoing; Wed, 31 Dec 1997 18:27:14 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id SAA02026 for ; Wed, 31 Dec 1997 18:27:11 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id TAA21099; Wed, 31 Dec 1997 19:22:39 -0500 Message-Id: <1.5.4.32.19980101002016.00695f70@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 19:20:16 -0500 To: PNG Implementation List From: Glenn Randers-Pehrson Subject: Re: Minor change to libpng libpng Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 10:53 PM 11/9/97 +0000, Tom Tanner wrote: > in pngrutil I have >changed the allocation of the palette to a png_zalloc Was there any further discussion about this? Tom, is there any more to that than simply changing the first letter "m" to "z" in the line in pngrutil.c palette = (png_colorp)png_malloc(png_ptr, num * sizeof (png_color)); glenn -- Send the message body "help" to png-implement-request@dworkin.wustl.edu From owner-png-implement@dworkin.wustl.edu Wed Dec 31 18:33:47 1997 Received: from dworkin.wustl.edu (dworkin.wustl.edu [128.252.169.2]) by swrinde.nde.swri.edu (8.8.8/8.8.5) with SMTP id SAA03375 for ; Wed, 31 Dec 1997 18:33:46 -0600 (CST) Received: (from daemon@localhost) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) id SAA02169 for png-implement-outgoing; Wed, 31 Dec 1997 18:38:08 -0600 Received: from grok.netgsi.com (grok.netgsi.com [192.55.203.19]) by dworkin.wustl.edu (8.6.10/8.6.6.yuck) with ESMTP id SAA02164 for ; Wed, 31 Dec 1997 18:38:05 -0600 Received: by NetGSI.com (8.8.7/-A/UX-AMR-1.0) id TAA21513; Wed, 31 Dec 1997 19:33:30 -0500 Message-Id: <1.5.4.32.19980101003107.006a2338@netgsi.com> X-Sender: glennrp@netgsi.com X-Mailer: Windows Eudora Light Version 1.5.4 (32) Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Wed, 31 Dec 1997 19:31:07 -0500 To: png-implement@dworkin.wustl.edu From: Glenn Randers-Pehrson Subject: Re: Minor change to libpng libpng Sender: owner-png-implement@dworkin.wustl.edu Precedence: bulk Reply-To: PNG Implementation List At 07:20 PM 12/31/97 -0500, I wrote: >At 10:53 PM 11/9/97 +0000, Tom Tanner wrote: >> in pngrutil I have >>changed the allocation of the palette to a png_zalloc > >Was there any further discussion about this? Tom, is there any >more to that than simply changing the first letter "m" to "z" in >the line in pngrutil.c > >palette = (png_colorp)png_malloc(png_ptr, num * sizeof (png_color)); > >glenn And changing the asterisk to a commma.. I went ahead and changed my copy as follows and it seems to work. palette = (png_colorp)png_zalloc(png_ptr, num, sizeof (png_color)); -- Send the message body "help" to png-implement-request@dworkin.wustl.edu